Conversation
kdzwinel
left a comment
kdzwinel
left a comment
There was a problem hiding this comment.
LGTM, but please update the documentation (https://github.com/duckduckgo/privacy-reference-tests/tree/main/privacy-configuration#privacy-configuration-tests) and pseudo-code to cover platformVersion field.
…acy-reference-tests into brad/config-v2-ref-tests
| "featureName": "contentBlocking", | ||
| "siteURL": "https://example.org", | ||
| "expectFeatureEnabled": false, | ||
| "platformVersion": "2022.5.30", |
There was a problem hiding this comment.
Will this test work for platforms other than extensions? e.g. android seems to use different format:
"minSupportedVersion": 51250000
They may not be able to implement this test (they may explode parsing that config file).
|
@SlayterDev any thoughts about what we should do about this one? Maybe separate versions for each platform version format? |
|
@kdzwinel apologies for the delay here. We might reach out to Android on this as they are the odd man out. In the example implementation I did for this in BSK I mocked the app versions so I wonder if for the purposes of the test they would be able to mock the version to a string or make this test work somehow. Otherwise we'll need to add a backup key to the test or a separate tests file. |
2 participants
Add
minSupportedVersionreference tests